nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-01-17 02:50:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(Core): apply clang-tidy modernize-use-nodiscard (#3835)

Browse Source
This commit is contained in:
Francesco Borzì
2020-12-06 19:39:48 +01:00
committed by GitHub
parent d4a58700d4
commit 161302252e
82 changed files with 1565 additions and 1569 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
src/server/game/Scripting/ScriptMgr.h
View File

@@ -151,11 +151,11 @@ public:
// Do not override this in scripts; it should be overridden by the various script type classes. It indicates
// whether or not this script type must be assigned in the database.
virtual bool IsDatabaseBound() const { return false; }
virtual bool isAfterLoadScript() const { return IsDatabaseBound(); }
[[nodiscard]] virtual bool IsDatabaseBound() const { return false; }
[[nodiscard]] virtual bool isAfterLoadScript() const { return IsDatabaseBound(); }
virtual void checkValidity() { }
const std::string& GetName() const { return _name; }
[[nodiscard]] const std::string& GetName() const { return _name; }
protected:
@@ -194,13 +194,13 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Should return a fully valid SpellScript pointer.
virtual SpellScript* GetSpellScript() const { return nullptr; }
[[nodiscard]] virtual SpellScript* GetSpellScript() const { return nullptr; }
// Should return a fully valid AuraScript pointer.
virtual AuraScript* GetAuraScript() const { return nullptr; }
[[nodiscard]] virtual AuraScript* GetAuraScript() const { return nullptr; }
};
class ServerScript : public ScriptObject
@@ -359,7 +359,7 @@ protected:
public:
bool isAfterLoadScript() const override { return true; }
[[nodiscard]] bool isAfterLoadScript() const override { return true; }
void checkValidity() override
{
@@ -378,7 +378,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
void checkValidity() override
{
@@ -400,7 +400,7 @@ protected:
public:
bool isAfterLoadScript() const override { return true; }
[[nodiscard]] bool isAfterLoadScript() const override { return true; }
void checkValidity() override
{
@@ -419,7 +419,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Called when a player accepts a quest from the item.
virtual bool OnQuestAccept(Player* /*player*/, Item* /*item*/, Quest const* /*quest*/) { return false; }
@@ -525,7 +525,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Called when a player opens a gossip dialog with the creature.
virtual bool OnGossipHello(Player* /*player*/, Creature* /*creature*/) { return false; }
@@ -563,7 +563,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Called when a player opens a gossip dialog with the gameobject.
virtual bool OnGossipHello(Player* /*player*/, GameObject* /*go*/) { return false; }
@@ -607,7 +607,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Called when the area trigger is activated by a player.
virtual bool OnTrigger(Player* /*player*/, AreaTrigger const* /*trigger*/) { return false; }
@@ -621,10 +621,10 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Should return a fully valid Battleground object for the type ID.
virtual Battleground* GetBattleground() const = 0;
[[nodiscard]] virtual Battleground* GetBattleground() const = 0;
};
@@ -636,10 +636,10 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Should return a fully valid OutdoorPvP object for the type ID.
virtual OutdoorPvP* GetOutdoorPvP() const = 0;
[[nodiscard]] virtual OutdoorPvP* GetOutdoorPvP() const = 0;
};
class CommandScript : public ScriptObject
@@ -651,7 +651,7 @@ protected:
public:
// Should return a pointer to a valid command table (ChatCommand array) to be used by ChatHandler.
virtual std::vector<ChatCommand> GetCommands() const = 0;
[[nodiscard]] virtual std::vector<ChatCommand> GetCommands() const = 0;
};
class WeatherScript : public ScriptObject, public UpdatableScript<Weather>
@@ -662,7 +662,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Called when the weather changes in the zone this script is associated with.
virtual void OnChange(Weather* /*weather*/, WeatherState /*state*/, float /*grade*/) { }
@@ -718,7 +718,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Called when a single condition is checked for a player.
virtual bool OnConditionCheck(Condition* /*condition*/, ConditionSourceInfo& /*sourceInfo*/) { return true; }
@@ -766,7 +766,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// Called when a player boards the transport.
virtual void OnAddPassenger(Transport* /*transport*/, Player* /*player*/) { }
@@ -789,7 +789,7 @@ protected:
public:
bool IsDatabaseBound() const override { return true; }
[[nodiscard]] bool IsDatabaseBound() const override { return true; }
// deprecated/legacy
virtual bool OnCheck(Player* /*source*/, Unit* /*target*/) { return true; };
@@ -1050,7 +1050,7 @@ protected:
public:
bool IsDatabaseBound() const override { return false; }
[[nodiscard]] bool IsDatabaseBound() const override { return false; }
// Called when a member is added to the guild.
virtual void OnAddMember(Guild* /*guild*/, Player* /*player*/, uint8& /*plRank*/) { }
@@ -1093,7 +1093,7 @@ protected:
public:
bool IsDatabaseBound() const override { return false; }
[[nodiscard]] bool IsDatabaseBound() const override { return false; }
// Called when a member is added to a group.
virtual void OnAddMember(Group* /*group*/, uint64 /*guid*/) { }
@@ -1150,7 +1150,7 @@ protected:
public:
bool IsDatabaseBound() const override { return false; }
[[nodiscard]] bool IsDatabaseBound() const override { return false; }
// Start Battlegroud
virtual void OnBattlegroundStart(Battleground* /*bg*/) { }
@@ -1188,7 +1188,7 @@ protected:
ArenaTeamScript(const char* name);
public:
bool IsDatabaseBound() const override { return false; };
[[nodiscard]] bool IsDatabaseBound() const override { return false; };
virtual void OnGetSlotByType(const uint32 /*type*/, uint8& /*slot*/) {}
virtual void OnGetArenaPoints(ArenaTeam* /*team*/, float& /*points*/) {}
@@ -1205,7 +1205,7 @@ protected:
public:
bool IsDatabaseBound() const override { return false; }
[[nodiscard]] bool IsDatabaseBound() const override { return false; }
// Calculate max duration in applying aura
virtual void OnCalcMaxDuration(Aura const* /*aura*/, int32& /*maxDuration*/) { }