nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-01-17 19:05:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core/Reputations): Faction rep gained by killing mobs is now prop… (#9737)

Browse Source 
* fix(Core/Reputations): Faction rep gained by killing mobs is now properly rounded up.

Do not increase reputation rank if exceeds max rank cap.
Fixes #8718
This commit is contained in:
UltraNix
2022-02-05 11:37:00 +01:00
committed by GitHub
parent 7b041946e1
commit 0b02ba87fc
11 changed files with 91 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/scripts/Commands/cs_modify.cpp
View File

@@ -851,7 +851,7 @@ public:
return false;
}
target->GetReputationMgr().SetOneFactionReputation(factionEntry, amount, false);
target->GetReputationMgr().SetOneFactionReputation(factionEntry, float(amount), false);
target->GetReputationMgr().SendState(target->GetReputationMgr().GetState(factionEntry));
handler->PSendSysMessage(LANG_COMMAND_MODIFY_REP, factionEntry->name[handler->GetSessionDbcLocale()], factionId,

4
src/server/scripts/Commands/cs_quest.cpp
View File

@@ -317,7 +317,7 @@ public:
{
if (FactionEntry const* factionEntry = sFactionStore.LookupEntry(repFaction))
{
player->GetReputationMgr().SetReputation(factionEntry, repValue);
player->GetReputationMgr().SetReputation(factionEntry, static_cast<float>(repValue));
}
}
}
@@ -331,7 +331,7 @@ public:
{
if (FactionEntry const* factionEntry = sFactionStore.LookupEntry(repFaction))
{
player->GetReputationMgr().SetReputation(factionEntry, repValue2);
player->GetReputationMgr().SetReputation(factionEntry, static_cast<float>(repValue2));
}
}
}

4
src/server/scripts/OutdoorPvP/OutdoorPvPSI.cpp
View File

@@ -113,7 +113,7 @@ bool OutdoorPvPSI::HandleAreaTrigger(Player* player, uint32 trigger)
// add 19 honor
player->RewardHonor(nullptr, 1, 19);
// add 20 cenarion circle repu
player->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20);
player->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20.f);
// complete quest
player->KilledMonsterCredit(SI_TURNIN_QUEST_CM_A);
}
@@ -139,7 +139,7 @@ bool OutdoorPvPSI::HandleAreaTrigger(Player* player, uint32 trigger)
// add 19 honor
player->RewardHonor(nullptr, 1, 19);
// add 20 cenarion circle repu
player->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20);
player->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20.f);
// complete quest
player->KilledMonsterCredit(SI_TURNIN_QUEST_CM_H);
}

2
src/server/scripts/Spells/spell_generic.cpp
View File

@@ -2463,7 +2463,7 @@ class spell_gen_oracle_wolvar_reputation : public SpellScript
// Set rep to baserep + basepoints (expecting spillover for oposite faction -> become hated)
// Not when player already has equal or higher rep with this faction
if (player->GetReputationMgr().GetReputation(factionEntry) <= repChange)
player->GetReputationMgr().SetReputation(factionEntry, repChange);
player->GetReputationMgr().SetReputation(factionEntry, static_cast<float>(repChange));
// EFFECT_INDEX_2 most likely update at war state, we already handle this in SetReputation
}