mirror of
https://github.com/uprightbass360/AzerothCore-RealmMaster.git
synced 2026-01-13 00:58:34 +00:00
feat: comprehensive module system and database management improvements
This commit introduces major enhancements to the module installation system, database management, and configuration handling for AzerothCore deployments. ## Module System Improvements ### Module SQL Staging & Installation - Refactor module SQL staging to properly handle AzerothCore's sql/ directory structure - Fix SQL staging path to use correct AzerothCore format (sql/custom/db_*/*) - Implement conditional module database importing based on enabled modules - Add support for both cpp-modules and lua-scripts module types - Handle rsync exit code 23 (permission warnings) gracefully during deployment ### Module Manifest & Automation - Add automated module manifest generation via GitHub Actions workflow - Implement Python-based module manifest updater with comprehensive validation - Add module dependency tracking and SQL file discovery - Support for blocked modules and module metadata management ## Database Management Enhancements ### Database Import System - Add db-guard container for continuous database health monitoring and verification - Implement conditional database import that skips when databases are current - Add backup restoration and SQL staging coordination - Support for Playerbots database (4th database) in all import operations - Add comprehensive database health checking and status reporting ### Database Configuration - Implement 10 new dbimport.conf settings from environment variables: - Database.Reconnect.Seconds/Attempts for connection reliability - Updates.AllowedModules for module auto-update control - Updates.Redundancy for data integrity checks - Worker/Synch thread settings for all three core databases - Auto-apply dbimport.conf settings via auto-post-install.sh - Add environment variable injection for db-import and db-guard containers ### Backup & Recovery - Fix backup scheduler to prevent immediate execution on container startup - Add backup status monitoring script with detailed reporting - Implement backup import/export utilities - Add database verification scripts for SQL update tracking ## User Import Directory - Add new import/ directory for user-provided database files and configurations - Support for custom SQL files, configuration overrides, and example templates - Automatic import of user-provided databases and configs during initialization - Documentation and examples for custom database imports ## Configuration & Environment - Eliminate CLIENT_DATA_VERSION warning by adding default value syntax - Improve CLIENT_DATA_VERSION documentation in .env.template - Add comprehensive database import settings to .env and .env.template - Update setup.sh to handle new configuration variables with proper defaults ## Monitoring & Debugging - Add status dashboard with Go-based terminal UI (statusdash.go) - Implement JSON status output (statusjson.sh) for programmatic access - Add comprehensive database health check script - Add repair-storage-permissions.sh utility for permission issues ## Testing & Documentation - Add Phase 1 integration test suite for module installation verification - Add comprehensive documentation for: - Database management (DATABASE_MANAGEMENT.md) - Module SQL analysis (AZEROTHCORE_MODULE_SQL_ANALYSIS.md) - Implementation mapping (IMPLEMENTATION_MAP.md) - SQL staging comparison and path coverage - Module assets and DBC file requirements - Update SCRIPTS.md, ADVANCED.md, and troubleshooting documentation - Update references from database-import/ to import/ directory ## Breaking Changes - Renamed database-import/ directory to import/ for clarity - Module SQL files now staged to AzerothCore-compatible paths - db-guard container now required for proper database lifecycle management ## Bug Fixes - Fix module SQL staging directory structure for AzerothCore compatibility - Handle rsync exit code 23 gracefully during deployments - Prevent backup from running immediately on container startup - Correct SQL staging paths for proper module installation
This commit is contained in:
@@ -82,6 +82,64 @@ def load_manifest(manifest_path: Path) -> List[Dict[str, object]]:
|
||||
return validated
|
||||
|
||||
|
||||
def discover_sql_files(module_path: Path, module_name: str) -> Dict[str, List[str]]:
|
||||
"""
|
||||
Scan module for SQL files.
|
||||
|
||||
Returns:
|
||||
Dict mapping database type to list of SQL file paths
|
||||
Example: {
|
||||
'db_auth': [Path('file1.sql'), ...],
|
||||
'db_world': [Path('file2.sql'), ...],
|
||||
'db_characters': [Path('file3.sql'), ...]
|
||||
}
|
||||
"""
|
||||
sql_files: Dict[str, List[str]] = {}
|
||||
sql_base = module_path / 'data' / 'sql'
|
||||
|
||||
if not sql_base.exists():
|
||||
return sql_files
|
||||
|
||||
# Map to support both underscore and hyphen naming conventions
|
||||
db_types = {
|
||||
'db_auth': ['db_auth', 'db-auth'],
|
||||
'db_world': ['db_world', 'db-world'],
|
||||
'db_characters': ['db_characters', 'db-characters'],
|
||||
'db_playerbots': ['db_playerbots', 'db-playerbots']
|
||||
}
|
||||
|
||||
for canonical_name, variants in db_types.items():
|
||||
# Check base/ with all variants
|
||||
for variant in variants:
|
||||
base_dir = sql_base / 'base' / variant
|
||||
if base_dir.exists():
|
||||
for sql_file in base_dir.glob('*.sql'):
|
||||
sql_files.setdefault(canonical_name, []).append(str(sql_file.relative_to(module_path)))
|
||||
|
||||
# Check updates/ with all variants
|
||||
for variant in variants:
|
||||
updates_dir = sql_base / 'updates' / variant
|
||||
if updates_dir.exists():
|
||||
for sql_file in updates_dir.glob('*.sql'):
|
||||
sql_files.setdefault(canonical_name, []).append(str(sql_file.relative_to(module_path)))
|
||||
|
||||
# Check custom/ with all variants
|
||||
for variant in variants:
|
||||
custom_dir = sql_base / 'custom' / variant
|
||||
if custom_dir.exists():
|
||||
for sql_file in custom_dir.glob('*.sql'):
|
||||
sql_files.setdefault(canonical_name, []).append(str(sql_file.relative_to(module_path)))
|
||||
|
||||
# ALSO check direct db-type directories (legacy format used by many modules)
|
||||
for variant in variants:
|
||||
direct_dir = sql_base / variant
|
||||
if direct_dir.exists():
|
||||
for sql_file in direct_dir.glob('*.sql'):
|
||||
sql_files.setdefault(canonical_name, []).append(str(sql_file.relative_to(module_path)))
|
||||
|
||||
return sql_files
|
||||
|
||||
|
||||
@dataclass
|
||||
class ModuleState:
|
||||
key: str
|
||||
@@ -103,6 +161,7 @@ class ModuleState:
|
||||
dependency_issues: List[str] = field(default_factory=list)
|
||||
warnings: List[str] = field(default_factory=list)
|
||||
errors: List[str] = field(default_factory=list)
|
||||
sql_files: Dict[str, List[str]] = field(default_factory=dict)
|
||||
|
||||
@property
|
||||
def blocked(self) -> bool:
|
||||
@@ -340,6 +399,30 @@ def write_outputs(state: ModuleCollectionState, output_dir: Path) -> None:
|
||||
encoding="utf-8",
|
||||
)
|
||||
|
||||
# Discover SQL files for all modules in output directory
|
||||
for module in state.modules:
|
||||
module_path = output_dir / module.name
|
||||
if module_path.exists():
|
||||
module.sql_files = discover_sql_files(module_path, module.name)
|
||||
|
||||
# Generate SQL manifest for enabled modules with SQL files
|
||||
sql_manifest = {
|
||||
"modules": [
|
||||
{
|
||||
"name": module.name,
|
||||
"key": module.key,
|
||||
"sql_files": module.sql_files
|
||||
}
|
||||
for module in state.enabled_modules()
|
||||
if module.sql_files
|
||||
]
|
||||
}
|
||||
sql_manifest_path = output_dir / ".sql-manifest.json"
|
||||
sql_manifest_path.write_text(
|
||||
json.dumps(sql_manifest, indent=2) + "\n",
|
||||
encoding="utf-8",
|
||||
)
|
||||
|
||||
|
||||
def print_list(state: ModuleCollectionState, selector: str) -> None:
|
||||
if selector == "compile":
|
||||
|
||||
Reference in New Issue
Block a user